Repository navigation
Redirect the remaining browser_extension, external_services and pure_docker paths - #2061
Merged
Merged
Conversation
…docker paths The underscore-to-hyphen rename (089d51a) added redirects only for pages whose own filename changed, so pages where only a directory changed were left out. Also point /admin/external_services/* straight at the hyphenated pages: postgres and redis led to the 404s above, and the other two went through another redirect. Restore /self-hosted/updates/pure_docker, which #1777 replaced with the hyphenated path. Amp-Thread-ID: https://ampcode.com/threads/T-58bff9ec-2d9e-4573-9e65-6cc7312f5f4a Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
marcleblanc2
approved these changes
Oct 2, 2026
2 of 4 tasks
marcleblanc2
enabled auto-merge (squash)
October 2, 2026 19:47
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2059, for the other sections with the same gap.
Problem
The underscore-to-hyphen rename (089d51a) added redirects only for pages whose own filename changed, so pages where only a directory changed were left out. These old paths return 404 today, though each page exists at its hyphenated path:
/integration/browser_extension/how-tos/integration/browser_extension/how-tos/troubleshooting/integration/browser_extension/quickstart/integration/browser_extension/references/integration/browser_extension/references/features/integration/browser_extension/references/privacy/self-hosted/external_services/postgres/self-hosted/external_services/redisRelated, in the same entries:
/admin/external_services/postgresand/admin/external_services/redisredirect to the/self-hosted/external_services/...paths above, so they also end in a 404./admin/external_servicesand/admin/external_services/object_storageare not broken: they already reach their page, through two redirects, for example/admin/external_services/object_storage→/self-hosted/external_services/object_storage→/self-hosted/external-services/object-storage. This PR only removes the middle step./self-hosted/updates/pure_docker(the URL before the rename) returns 404: chore/platform: deprecate pure docker deployment #1777 changed that entry's source to/self-hosted/updates/pure-dockerinstead of adding a second entry.Fix
/admin/external_services*entries straight at the hyphenated pages, so each takes one redirect. Forpostgresandredisthis fixes the 404; for/admin/external_servicesandobject_storageit only shortens two redirects to one./self-hosted/updates/pure_docker→/self-hosted/deploy/docker-compose/upgrade, the same destination aspure-docker.Test plan
node dev/check-redirects.mjs --baseline <main>.json:✅ No redirects broken by this change. Total findings drop from 542 to 538 (the four/admin/external_services*entries).proxy()with aNextRequestfor all 13 paths: each returns 307 to a page that exists underdocs/./cli/references/*,/notebooks/*,/self-hosted/deploy/docker-single-container/*,/admin/teams,/admin/access_control/ownership,/admin/repo/pre_load_from_local_disk.