ci/hostnames: Add example hostnames PR check - #2039
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
This comment has been minimized.
This comment has been minimized.
Contributor
|
Direct preview links to pages changed in this PR: |
Contributor
✅ This revision uses only recommended example hostnames |
Advisory check that flags placeholder hostnames on lines a PR adds that are not the recommended *.example.com ones, and suggests the replacement as a one-click review comment. dev/example-hostnames.json maps each recommended hostname to the placeholders #1932 replaced with it; bare fake company domains match as a hostname tail so the subdomain carries over. Amp-Thread-ID: https://ampcode.com/threads/T-01a0d69d-e558-73b8-99b1-e238a0588c49 Co-authored-by: Amp <amp@ampcode.com>
Mapping entries can be literal text, a glob where `*` matches a run of hostname characters, or a `/regex/`. Matching ignores case, and `-`, `_`, and `.` in literal and glob entries match any of the three, so one entry covers the spelling variants the docs used. The JSON is 2-space indented with keys and lists sorted, and the duplicated literals are folded into glob and regex entries, including the patterns from #1933. The workflow runs only when a PR touches docs/ or the check itself. Amp-Thread-ID: https://ampcode.com/threads/T-01a0fdce-6d4c-708e-a1ac-c5a8f9e48a65 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
force-pushed
the
marc/ci/check-hostnames
branch
from
October 2, 2026 18:33
9c67b74 to
e62f72f
Compare
<URL>, <external url>, <your externalURL here>, $SOURCEGRAPH_ORIGIN, [hostname], <your-git-host>, <the domain>: the spellings that docs/ still uses in prose and config samples where a hostname is meant. Amp-Thread-ID: https://ampcode.com/threads/T-01a0fdce-6d4c-708e-a1ac-c5a8f9e48a65 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0fdce-6d4c-708e-a1ac-c5a8f9e48a65 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0fdce-6d4c-708e-a1ac-c5a8f9e48a65 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
enabled auto-merge (squash)
October 2, 2026 20:21
enriquegh
approved these changes
Oct 2, 2026
marcleblanc2
disabled auto-merge
October 2, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps maintain consistency and readability by adding a non-blocking PR check to flag placeholder hostnames and suggest replacements as one-click review comments
dev/example-hostnames.jsonmaps recommended example hostnames to lists of example hostnames we've seen, as literal text, a*glob, or a/regex/Also deletes a stray
dev/TODO.md