You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @weiningwei, thanks for this PR! I ran into the same need for CommitBaseInfo's SHA copy button and, as a follow-up, ended up building a reusable CopyButton control (#2668), covering both LauncherPage and CommitBaseInfo. It touches the same lines in LauncherPage.axaml(.cs), so merging both would conflict. Would you be open to rebasing this on top of CopyButton so we land on one consistent solution? Happy to help adjust either side.
Hi @JC-Chung, congrats on #2668 being merged — the reusable CopyButton is a nice cleanup, and thanks for the heads-up here.
I've rebased this PR on top of it. Since the notification copy feedback is now fully covered by CopyButton, this PR is reduced to a single line: adding the missing Text.Copy tooltip to the CopyButton in LauncherPage — the same tooltip CommitBaseInfo already has, so both usages stay consistent. @love-linger Just want to confirm: is this one-liner worth keeping as a separate PR, or would you rather not have the tooltip there at all? Happy to close if it's unnecessary.
weiningwei
changed the title
ux: show copy feedback icon when copying notification message
ux: add tooltip to copy button in Launcher notification
Sep 1, 2026
I did notice the tooltip aspect, but since the dismiss button next to it doesn't have one either, I kept it as-is. If we're adding one now, maybe we should also consider adding a tooltip to the dismiss button? No rush to change it right away though — might be worth waiting to hear what the @love-linger think first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shows a transient checkmark icon as visual feedback when the user copies a notification message, then resets back to the copy icon after one second.
Changes
Notificationobservable (ObservableObject) and add anIsCopiedproperty.IsCopied.DispatcherTimerinLauncherPageto resetIsCopiedone second after copying.