Skip to content

ux: add tooltip to copy button in Launcher notification - #2666

Merged
love-linger merged 1 commit into
sourcegit-scm:developfrom
weiningwei:feature/notification-copy-feedback
Sep 2, 2026
Merged

ux: add tooltip to copy button in Launcher notification#2666
love-linger merged 1 commit into
sourcegit-scm:developfrom
weiningwei:feature/notification-copy-feedback

Conversation

@weiningwei

Copy link
Copy Markdown
Contributor

What

Shows a transient checkmark icon as visual feedback when the user copies a notification message, then resets back to the copy icon after one second.

Changes

  • Make Notification observable (ObservableObject) and add an IsCopied property.
  • Toggle between the copy icon and a green checkmark in the launcher notification item based on IsCopied.
  • Add a DispatcherTimer in LauncherPage to reset IsCopied one second after copying.
  • Add a tooltip to the copy button.

@JC-Chung

JC-Chung commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Hi @weiningwei, thanks for this PR! I ran into the same need for CommitBaseInfo's SHA copy button and, as a follow-up, ended up building a reusable CopyButton control (#2668), covering both LauncherPage and CommitBaseInfo. It touches the same lines in LauncherPage.axaml(.cs), so merging both would conflict. Would you be open to rebasing this on top of CopyButton so we land on one consistent solution? Happy to help adjust either side.

@weiningwei
weiningwei force-pushed the feature/notification-copy-feedback branch from 6b9c24e to 7a4674a Compare September 1, 2026 13:55
@weiningwei

weiningwei commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Hi @JC-Chung, congrats on #2668 being merged — the reusable CopyButton is a nice cleanup, and thanks for the heads-up here.
I've rebased this PR on top of it. Since the notification copy feedback is now fully covered by CopyButton, this PR is reduced to a single line: adding the missing Text.Copy tooltip to the CopyButton in LauncherPage — the same tooltip CommitBaseInfo already has, so both usages stay consistent.
@love-linger Just want to confirm: is this one-liner worth keeping as a separate PR, or would you rather not have the tooltip there at all? Happy to close if it's unnecessary.

@weiningwei weiningwei changed the title ux: show copy feedback icon when copying notification message ux: add tooltip to copy button in Launcher notification Sep 1, 2026
@JC-Chung

JC-Chung commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

I did notice the tooltip aspect, but since the dismiss button next to it doesn't have one either, I kept it as-is. If we're adding one now, maybe we should also consider adding a tooltip to the dismiss button? No rush to change it right away though — might be worth waiting to hear what the @love-linger think first.

@love-linger love-linger self-assigned this Sep 2, 2026
@love-linger love-linger added the enhancement New feature or request label Sep 2, 2026
@love-linger
love-linger merged commit a343c08 into sourcegit-scm:develop Sep 2, 2026
13 of 14 checks passed
@weiningwei
weiningwei deleted the feature/notification-copy-feedback branch September 2, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants