chore: upgrade Go toolchain 1.25 & zoekt version#1112
Conversation
Resolves CVE-2025-68121 (CRITICAL, crypto/tls certificate validation during TLS session resumption) and multiple HIGH/MEDIUM Go stdlib CVEs across all zoekt binaries. Also pulls latest zoekt submodule (dec971a, bump dependencies #9) which updates go.mod to go 1.25.0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
WalkthroughThe pull request updates the Go toolchain from version 1.23.4 to 1.25, addressing CVE-2025-68121 and additional Go standard library vulnerabilities. The Dockerfile Go builder image and vendor/zoekt submodule are updated correspondingly. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Dockerfile (1)
19-19: Pin the Go builder image more tightly to keep builds reproducible.
golang:1.25-alpineis a floating tag; patch/Alpine drift can cause non-deterministic CI behavior. Pin to a specific patch version (e.g.,golang:1.25.0-alpine) or digest instead.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile` at line 19, The Dockerfile uses a floating builder image tag "golang:1.25-alpine" in the FROM instruction which can cause non-deterministic builds; update the FROM line to pin the Go builder to a specific patch version (e.g., "golang:1.25.0-alpine") or, better, to an immutable digest for reproducibility, ensuring the image reference is stable for CI and local builds.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Dockerfile`:
- Line 19: The Dockerfile uses a floating builder image tag "golang:1.25-alpine"
in the FROM instruction which can cause non-deterministic builds; update the
FROM line to pin the Go builder to a specific patch version (e.g.,
"golang:1.25.0-alpine") or, better, to an immutable digest for reproducibility,
ensuring the image reference is stable for CI and local builds.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a1e93270-e7bf-4067-829f-d7257ef6a7df
📒 Files selected for processing (3)
CHANGELOG.mdDockerfilevendor/zoekt
bump zoekt dependency & upgrade to go 1.25
Summary by CodeRabbit
Bug Fixes
Chores