Skip to content

fix(signals): remove unsupported single-argument createEffect - #3211

Merged
ryansolid merged 1 commit into
solidjs:nextfrom
Monkeylordz:fix/remove-deprecated-create-effect-overload
Sep 2, 2026
Merged

fix(signals): remove unsupported single-argument createEffect#3211
ryansolid merged 1 commit into
solidjs:nextfrom
Monkeylordz:fix/remove-deprecated-create-effect-overload

Conversation

@Monkeylordz

@Monkeylordz Monkeylordz commented Sep 2, 2026

Copy link
Copy Markdown

Summary

The single-argument createEffect overload was marked deprecated for migration purposes, but in reality it just leads to hidden runtime errors.

  • remove the unsupported single-argument createEffect(compute) overload so TypeScript rejects the call
  • remove the development-only MISSING_EFFECT_FN guard and diagnostic
  • update type coverage, diagnostic documentation, and changesets

Testing

  • pnpm --dir packages/signals exec vitest run tests/createEffect.test.ts tests/diagnostics.test.ts (44 tests passed)
  • pnpm --dir packages/solid test-types

- Remove the deprecated overload and MISSING_EFFECT_FN diagnostic
- Require an explicit effect callback in types and runtime
@changeset-bot

changeset-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 75a22b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 11 packages
Name Type
solid-js Patch
@solidjs/element Patch
@solidjs/h Patch
@solidjs/html Patch
test-integration Patch
@solidjs/universal Patch
@solidjs/web Patch
@solidjs/babel-plugin Patch
@solidjs/compiler Patch
@solidjs/diagnostics Patch
@solidjs/signals Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid
ryansolid merged commit 281aeaa into solidjs:next Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants