fix(solid): keep generated declarations private - #3106
Merged
Conversation
🦋 Changeset detectedLatest commit: 21ccb7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
solid-js/types/*package exportsolid-jsentry point instead of emitted client/server declaration modulesContext
The wildcard makes every generated declaration module a public auto-import source. In a configured Solid project, TypeScript consequently offers both
solid-jsandsolid-js/types/server/signals.jsforcreateSignal. The latter has no matching runtime file and fails when emitted as a value import.The wildcard was introduced for Solid 1 internal type consumers. Those old declaration paths are not present in Solid 2, while the supported values and types are exposed from the package root.
Test plan
pnpm --filter ./packages/signals run buildpnpm --filter ./packages/solid run typespnpm --filter ./packages/solid run test-typespnpm --filter ./packages/solid run buildpnpm --filter ./packages/solid exec vitest run(576 tests)solid-js; its 10 tests and client/SSR Vite build pass