fix: URL to path conversion in manifest resolver#2141
Merged
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 508e7f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
2 tasks
Contributor
|
Could you please add a changeset. Also if possible add some tests for this? |
Contributor
Author
|
Added changeset. I'm not sure how to write a test for the fix. |
silen-z
force-pushed
the
main
branch
5 times, most recently
from
29dcd12 to
f4e593b
Compare
Contributor
Author
|
Is the project not formatted according to the oxfmt config? Because I run |
atk
approved these changes
May 29, 2026
Contributor
|
@silen-z Thank you for the fix 💙! |
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Resolving of virtual module
solid-start:get-manifestfails when path contains spaces.What is the new behavior?
Path gets converted and resolved correctly even when it contains spaces.