Skip to content

added Meeting object - for review#6

Open
tgra wants to merge 21 commits intosolid:mainfrom
tgra:meeting-object
Open

added Meeting object - for review#6
tgra wants to merge 21 commits intosolid:mainfrom
tgra:meeting-object

Conversation

@tgra
Copy link
Member

@tgra tgra commented Feb 9, 2026

Comment on lines +14 to +20
<https://example.org/meeting/1> a cal:Vevent ;

cal:summary "Team Sync" ;
cal:location "Zoom Room 123" ;
cal:comment "Discuss project updates" ;
cal:dtstart "2026-02-09T10:00:00Z"^^xsd:dateTime ;
cal:dtend "2026-02-09T11:00:00Z"^^xsd:dateTime .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that is what corresponds to the current shape in the pane.

However, could you find a few slightly more comprehensive ical events examples so that we create a class that might be a bit more usable?

I wonder if we can get at least the properties corresponding to the main fields in all well known calendar systems. See maybe RFC5545 section 4 for examples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"get at least the properties corresponding to the main fields in all well known calendar systems" Just to confirm @matthieubosquet, you'd like to add new properties to Meeting.ts and then add corresponding test cases? The existing properties are based on the SolidOS shape for Meeting at https://github.com/solid/shape-generation-artefacts/tree/main/shapes/Meeting with ref to https://github.com/SolidOS/meeting-pane/blob/main/src/meetingDetailsForm.ttl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it would be worth considering a test pattern for mutations where

  1. Test has some RDF in Turtle
  2. RDF is is loaded into a dataset
  3. Dataset is wrapped by mapping classes
  4. Instances of wrappers are mutated
  5. Actual dataset is asserted to be isomorphic with an expected dataset

This is more robust in a way because it does not rely on ther wrappers for reading out values modified by the wrapper itself.

tgra and others added 18 commits February 16, 2026 09:43
Co-authored-by: Matthieu Bosquet <matthieubosquet@gmail.com>
Co-authored-by: Matthieu Bosquet <matthieubosquet@gmail.com>
Co-authored-by: Matthieu Bosquet <matthieubosquet@gmail.com>
Co-authored-by: Matthieu Bosquet <matthieubosquet@gmail.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Matthieu Bosquet <matthieubosquet@gmail.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants