correct deposit liquidity ratio #505 #513
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deposit_liquidity instruction was incorrectly multiplying pool amounts instead of dividing them to calculate the ratio between Pool Token A and Pool Token B. This caused incorrect LP token minting calculations for subsequent deposits. This change fixes the logic to use division: Ratio = Pool A / Pool B.
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two critical logic bugs in the deposit_liquidity instruction:
Ratio Calculation Fix: The code was incorrectly multiplying pool amounts (pool_a * pool_b) instead of dividing (pool_a / pool_b) to determine the current pool ratio. This led to incorrect LP token calculations.
Arbitrarily selected which input amount to use based on if pool_a > pool_b, which could cause transactions to fail even when users provided sufficient funds