fix(tokens/token-swap): deposit ratio bug #505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Token Swap program example,
The current
deposit_liquidityinstruction checks the existing liquidity to establish atokenA/tokenBratio, but it has a bug.program-examples/tokens/token-swap/anchor/programs/token-swap/src/instructions/deposit_liquidity.rs
Lines 40 to 60 in 8e0879b
Specifically here (notice the multiplication instead of division)
I fixed that and added a tests to verify the desired behavior: