Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for React Native 0.84.0-rc.3 by updating dependencies and iOS build configurations. As noted in the PR description, no specific code changes were required for Gesture Handler compatibility with React Native 0.84.
Changes:
- Updated React Native and related dependencies from 0.83.0 to 0.84.0-rc.3
- Updated iOS Podfile.lock to reflect React Native 0.84's new dependency structure (consolidated third-party deps)
- Enhanced iOS project configuration with iPad support and new architecture flags
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-native-gesture-handler/package.json | Updated React Native and related devDependencies to 0.84.0-rc.3 |
| apps/basic-example/package.json | Updated React Native dependencies to 0.84.0-rc.3 and raised Node.js requirement to >=22.11.0 |
| apps/basic-example/ios/Podfile.lock | Updated all iOS pod dependencies to 0.84.0-rc.3, removed consolidated dependencies (boost, RCT-Folly, SocketRocket), added new dependencies (React-Core-prebuilt, ReactNativeDependencies, React-jsitooling) |
| apps/basic-example/ios/BasicExample/Info.plist | Added separate orientation support for iPad devices |
| apps/basic-example/ios/BasicExample.xcodeproj/project.pbxproj | Added build settings for new architecture support, explicit device family targeting, and Swift module configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
Until now, no specific changes were necessary to make Gesture Handler compatible with React Native 0.84.
Status
0.84.0-rc.3 ✅
Test plan
Tested that
basic-examplebuilds and works correctly.