Fix border styling issues in RNGestureHandlerButton#3409
Fix border styling issues in RNGestureHandlerButton#3409
RNGestureHandlerButton#3409Conversation
|
I'm not sure whether this is the right approach. React Native overrides the native I think an approach with two views, where the outer one applies styling and the inner one is the actual button, would be safer and work on both platforms (iOS suffers from the same problem). We tried that in the past and failed, but now we could build it relying on |
Description
This PR adds missing prop styles fields to the RNGestureHandlerButton delegate.
Since a lot of new logic would be required to support these new props, I decided to also rewrite
ButtonViewGroupto useReactViewGroupinstead ofViewGroup, as our current implementation seemed to already share most of it's drawing-related code with theReactViewGroup.The only logic missing from
ReactViewGroupwas theripplelogic, the foreground logic, and the touch handling logic, so i kept those in place. Remaining redundant code was removed.Fixes #3304
Test plan
Collapsed example