impr: console.warn with suggestion when trying to define a variable of an unknown type#1992
Closed
cieplypolar wants to merge 17 commits intomainfrom
Closed
impr: console.warn with suggestion when trying to define a variable of an unknown type#1992cieplypolar wants to merge 17 commits intomainfrom
cieplypolar wants to merge 17 commits intomainfrom
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (334 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
8968724 to
524fb4b
Compare
Collaborator
|
We could move the error up where we have more context, and append the suggestion to the error. |
ecc1657 to
77ffb35
Compare
iwoplaza
approved these changes
Jan 21, 2026
Collaborator
iwoplaza
left a comment
There was a problem hiding this comment.
I once again approve 👍
Collaborator
Author
|
Done in #2032. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1991.