Skip to content

fix(sio): reset regex lastIndex when matching dynamic namespaces #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spokodev wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

fix(sio): reset regex lastIndex when matching dynamic namespaces #5519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/socket.io/lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,10 +788,12 @@ export class Server<
if (typeof name === "function") {
this.parentNsps.set(name, parentNsp);
} else {
this.parentNsps.set(
(nsp, conn, next) => next(null, (name as RegExp).test(nsp)),
parentNsp,
);
this.parentNsps.set((nsp, conn, next) => {
// Reset lastIndex so a regex created with the global or sticky flag
// matches consistently across connections.
(name as RegExp).lastIndex = 0;
next(null, (name as RegExp).test(nsp));
}, parentNsp);
this.parentNamespacesFromRegExp.set(name, parentNsp);
}
if (fn) {
Expand All @@ -806,6 +808,9 @@ export class Server<
let nsp = this._nsps.get(name);
if (!nsp) {
for (const [regex, parentNamespace] of this.parentNamespacesFromRegExp) {
// Reset lastIndex so a regex created with the global or sticky flag
// matches consistently across connections.
regex.lastIndex = 0;
if (regex.test(name as string)) {
debug("attaching namespace %s to parent namespace %s", name, regex);
return parentNamespace.createChild(name as string);
Expand Down