Fixing Crashes related to Concurrency#776
Closed
Harsh5488 wants to merge 1 commit intosocketio:mainfrom
Harsh5488:main-fixing-concurrency
Closed
Fixing Crashes related to Concurrency#776Harsh5488 wants to merge 1 commit intosocketio:mainfrom Harsh5488:main-fixing-concurrency
Harsh5488 wants to merge 1 commit intosocketio:mainfrom
Harsh5488:main-fixing-concurrency
Conversation
• Making clearAcks() public for clearing acknowledgement when needed
Contributor
Author
|
It can solve the issues related to the concurrency |
|
@Harsh5488 good job! I had a similar problem with clearing the queue. @darrachequesne +1 for public clearAcks |
Contributor
Author
|
@darrachequesne |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Using ConcurrentHashMap for multi-threaded environment
• Making clearAcks() public for clearing acknowledgement when needed