[CRE-4972] Test that capabilities and workflows DONs are only attached to each other if share the same family - #23782
Merged
Merged
Conversation
pavel-raykov
changed the title
Contributor
|
✅ No conflicts with other open PRs targeting |
pavel-raykov
changed the title
|
mchain0
approved these changes
Sep 21, 2026
george-dorin
approved these changes
Sep 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two tests:
TestLauncher_OnNewRegistry_FiltersRemoteCapabilityDONsByFamilytests that a workflow DON is only connected to the capability DON from the same family. UnlikeTestLauncher_ShardedCapabilityRoutingByFamilyit tests the non-connection with a capability by explicitly querying the local registry (this is now possible because the non-connected capability DON uses a different capability ID)TestLauncher_OnNewRegistry_FiltersRemoteWorkflowDONsByFamilyis the the serve-side mirror ofTestLauncher_OnNewRegistry_FiltersRemoteCapabilityDONsByFamily: it tests that a capability DON is only serving the workflow DON from the same family. This is the first test that explicitly checks that the capability serving Server would 1. has expected config with the workflow DON from the same family and 2. reject messages from the workflow DONs with a different family.