Skip to content

CCIP-13390: Pass lane version resolver to ConnectChains in ccip test helpers - #23769

Merged
athegaul merged 6 commits into
developfrom
CCIP-13390/lane-validation-args
Sep 21, 2026
Merged

athegaul merged 6 commits into
developfrom
CCIP-13390/lane-validation-args

Conversation

@athegaul

Copy link
Copy Markdown
Contributor

Update the Aptos and Sui/Solana lane test helpers to the new 3-arg ConnectChains signature (nil resolver for v1.6.0 lanes) and bump chainlink-ccip to the merged lane prerequisites commit.

…helpers

Update the Aptos and Sui/Solana lane test helpers to the new 3-arg ConnectChains signature (nil resolver for v1.6.0 lanes) and bump chainlink-ccip to the merged lane prerequisites commit.
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Sep 17, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_Solana_Read_Accounts The test failed because it couldn't download Solana artifacts due to a 504 gateway timeout error. Logs ↗︎
TestRMNCurseOneConnectedLanesGlobalOnly The test failed because it could not download the required artifact due to a 504 gateway timeout. Logs ↗︎
TestTokenTransfer_Solana2EVM The test failed because it could not download the required artifact due to a 504 gateway timeout. Logs ↗︎
TestRMNUncurseForceOption/RMNCurseForceOptionFalse The test failed because a required file 'ccip_router.so' was not found, causing an error during setup. Logs ↗︎

... and 10 more

View Full Report ↗︎Docs

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

jmank88
jmank88 previously approved these changes Sep 17, 2026
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@athegaul
athegaul requested a review from jmank88 September 21, 2026 17:06
@athegaul
athegaul added this pull request to the merge queue Sep 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 21, 2026
@athegaul
athegaul added this pull request to the merge queue Sep 21, 2026
Merged via the queue into develop with commit 0c381be Sep 21, 2026
284 of 311 checks passed
@athegaul
athegaul deleted the CCIP-13390/lane-validation-args branch September 21, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants