feat(protocol): carry the retry wait on a failed Resolution - #162
Merged
Merged
Conversation
A rate limited install printed "the Resolution failed and may be retried", which says nothing a person can act on. The wire contract now carries an optional retryAfterSeconds, the CLI prints the wait, and a bulk add stops at the first rate limit instead of spending the same exhausted budget on every Skill left.
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. Waiting for Baseline repair e1afcc6c14ca387916133353537846173088edd1aec59af1d6ee5920d817ce67. |
harlan-github-agent
Bot
removed
the
harlan-agent-pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Installing 33 Skills from one Repository exhausts skilld.dev's GitHub budget partway through, and every Skill after that fails like this:
Nineteen of those, each one spending a resolution against a quota that was already gone, and none of them saying the one thing worth knowing: when it would work again.
ResolutionFailedgains an optionalretryAfterSeconds. skilld.dev knows the wait, because GitHub sendsx-ratelimit-reset, and skilld-dev/skilld.dev#275 carries it through. The CLI prints it, and a bulkaddstops at the first rate limit rather than working through the rest:The field is optional, so a service that does not send it behaves exactly as before.
Question for you: stopping the whole run on the first
RATE_LIMITEDis a judgement call. A per-Repository limit would argue for skipping to the next Repository instead, but a ref names one Repository today, so there is nothing to skip to.