feat(cli): make the Skill picker readable and filterable - #159
Merged
Merged
Conversation
The picker opened with all 33 Skills chosen, printed [x] against every one, and let long descriptions run off the right edge. It now opens with nothing chosen, aligns the names into a column, cuts each description to the terminal width, and colors the marks, the counts and the key hints.
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 87513816-391e-41ac-804e-69ec01f848a3 |
Choosing 3 Skills from 33 meant walking the whole list. Press / and type: the list narrows on name and description, a takes everything the filter shows, and esc clears the filter before it cancels the picker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
The picker opened with every Skill chosen, so on a 33 Skill Repository the fastest path to "I want three of these" was 30 keystrokes of unchoosing. It opens with nothing chosen now.
--allalready covers the install-everything case, and an empty list makes the count in the header mean something as you work down.The rest is legibility. Descriptions ran off the right edge and the marks were
[x]and[ ]in plain white:Now:
Names align into one column, each description is cut to the terminal width rather than wrapped, chosen marks are green, the cursor row is bold, and the key hints are lit.
NO_COLORturns all of it off.Choosing 3 Skills from 33 still meant walking the whole list, so
/now filters as you type, on name and description:athen takes everything the filter shows, so filter,a, filter,ais the fast path through a big Repository. Chosen Skills survive filter changes, the header counts both, enter keeps the filter and hands the letter keys back, and esc clears the filter before it cancels the picker.Not in this PR: those
\"sequences in the descriptions are real, and they are a skilld.dev indexing bug. The SKILL.md frontmatter is a valid double-quoted YAML scalar, so\"pinia\"should decode to"pinia"when the registry stores it. Fixing that at the source rather than papering over it in the terminal.