Skip to content

feat(slack): switch custom bots to the Sim Search app - #7811

Merged
TheodoreSpeaks merged 4 commits into
stagingfrom
codex/slack-shared-install-action
Sep 14, 2026
Merged

TheodoreSpeaks merged 4 commits into
stagingfrom
codex/slack-shared-install-action

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Let admins install the Sim Search app from an existing custom bot's connection menu.
  • Activate the replacement and disable the custom bot in one transaction after OAuth, preserving existing personal source connections.
  • Reply to DMs sent to the retired bot with an Open Sim Search button, using the active replacement in the same organization and Slack workspace.
  • Limit shared-app setup to hosted deployments with the rollout flag enabled, simplify the installation dialog, and show completion as a toast.

Type of Change

  • New feature

Testing

  • Focused tests passed, covering OAuth transitions, reconnects, stale configuration, authorization, source preservation, managed-user setup, settings behavior, and deduplicated handoff replies. The handoff validation passed 370 tests across 30 suites.
  • Full lint, repository audits, block registry, and docs manifest checks passed. Typechecks run in CI.
  • Verified the settings UI and shared-app OAuth reconnect manually. Live handoff and full model-response validation remain pending.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 14, 2026 8:40pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding findings or newly introduced actionable issues.

Summary

This PR migrates eligible custom Slack Search bots to the hosted Sim Search app while preserving existing personal source connections.

  • Adds an atomic OAuth transition that activates the shared app and disables the replaced custom bot.
  • Adds authorization and durable, deduplicated DM handoff replies for retired bots.
  • Restricts shared-app availability to hosted deployments with the rollout flag enabled.
  • Updates settings UI, OAuth state, manifests, message rendering, and focused test coverage.

Diagram

sequenceDiagram
    participant Admin
    participant Sim
    participant Slack
    participant DB
    participant RetiredBot as Retired custom bot
    participant SharedApp as Sim Search app

    Admin->>Sim: Install Sim Search from custom bot
    Sim->>Slack: Start shared-app OAuth
    Slack-->>Sim: OAuth callback
    Sim->>DB: Transaction: disable custom bot and activate shared app
    Sim-->>Admin: Slack connected toast

    Admin->>RetiredBot: Send DM after migration
    RetiredBot->>Sim: Deliver message event
    Sim->>DB: Persist deduplicated handoff turn
    Sim->>RetiredBot: Post Open Sim Search button
    Admin->>SharedApp: Continue conversation
Loading

Reviews (5) · Last reviewed commit: "feat(slack): link retired bots to the Si..."

@TheodoreSpeaks TheodoreSpeaks changed the title fix(slack): show shared app installation beside custom bots feat(slack): switch custom bots to the Sim Search app Sep 14, 2026
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/lib/slack-search/manifest.ts
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

Comment thread apps/sim/app/o/[organizationId]/settings/components/organization-search-slack.tsx Outdated
@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@TheodoreSpeaks
TheodoreSpeaks merged commit 0734cd0 into staging Sep 14, 2026
33 of 34 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/slack-shared-install-action branch September 14, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant