Skip to content

fix(chat): share thinking and preserve natural activity labels - #7810

Merged
waleedlatif1 merged 4 commits into
stagingfrom
codex/activity-thinking-labels
Sep 14, 2026
Merged

waleedlatif1 merged 4 commits into
stagingfrom
codex/activity-thinking-labels

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Share one gooey thinking indicator across empty parallel and nested agents. Show individual rows when meaningful activity arrives, preserving tool history, approval controls, icons, and existing spacing and timing.
  • Preserve successful activity descriptions without adding “Completed:”; retain known past-tense conversions and explicit failure, stopped, and skipped outcomes.

Type of Change

  • Bug fix

Testing

849 targeted tests passed across activity rendering, nested and parallel agents, terminal and permission states, narration, transcript sizing, completion labels, browser/integration icons, and the thinking loader. Type-check, lint, all 46 audits, block-registry and docs-manifest checks passed. Verified the rendered comparison in dark and light modes, including first-action transitions, row spacing, expansion, and the Google favicon.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 14, 2026 6:05pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previous documentation requirement is satisfied and no new actionable defects remain.

Summary

  • Filters empty and whitespace-only agent lanes from rendered activity.
  • Keeps pending, terminal, approval, and nested activity visible.
  • Preserves successful descriptions unless a known past-tense conversion applies.
  • Adds focused coverage for shared thinking, activity transitions, and outcome labels.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Streaming assistant turn] --> B{Pending agent lanes?}
  B -->|Only empty lanes| C[Show shared turn-level thinking indicator]
  B -->|Meaningful activity exists| D[Render agent activity rows]
  D --> E{Tool outcome}
  E -->|Executing| F[Show active description]
  E -->|Success| G[Apply known past-tense rewrite or preserve description]
  E -->|Failed, stopped, or skipped| H[Show explicit terminal outcome]
Loading

Reviews (4) · Last reviewed commit: "docs(chat): explain pending activity own..."

@waleedlatif1
waleedlatif1 force-pushed the codex/activity-thinking-labels branch from a939297 to 6c79f92 Compare September 14, 2026 17:59
@waleedlatif1 waleedlatif1 changed the title fix(chat): use shared thinking and natural completion labels fix(chat): share thinking and preserve natural activity labels Sep 14, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1
waleedlatif1 merged commit 5613e74 into staging Sep 14, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/activity-thinking-labels branch September 14, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant