Skip to content

improvement(search): simplify GitHub App setup dialog - #7714

Merged
icecrasher321 merged 1 commit into
stagingfrom
codex/github-search-modal
Sep 10, 2026
Merged

improvement(search): simplify GitHub App setup dialog#7714
icecrasher321 merged 1 commit into
stagingfrom
codex/github-search-modal

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

  • Simplify GitHub App setup to one field with the installation selector and Install/Refresh controls.
  • Show installation guidance only when no installations are available. Keep the account-connection instructions, loading states, and errors for the steps that need them.

Type of Change

  • Improvement

Testing

91 existing setup and installation-modal tests passed. App type-check, lint, all 46 repository audits, block registry, and docs manifest checks passed. Connection and authorization behavior is unchanged.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing tests passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 10, 2026 3:10am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no concrete behavioral, accessibility, security, or repository-rule regression was identified.

Summary

  • Shows account-connection instructions when a user connection is required.
  • Shows installation guidance only when no eligible installations exist.
  • Keeps loading, unavailable, error, Install, and Refresh states intact.
  • Preserves existing installation selection and authorization behavior.

Reviews (1) · Last reviewed commit: "improvement(search): simplify GitHub App..."

@icecrasher321
icecrasher321 merged commit 2aa642e into staging Sep 10, 2026
33 checks passed
@icecrasher321
icecrasher321 deleted the codex/github-search-modal branch September 10, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant