Skip to content

fix(ci): validate stacked PRs against explicit audit bases - #7662

Open
BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
fix/platform-stacked-ci
Open

fix(ci): validate stacked PRs against explicit audit bases#7662
BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
fix/platform-stacked-ci

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Run the existing non-deploying validation for same-repository stacked PRs, while retaining primary-base fork PR coverage and existing push/deployment gates.
  • Pin PR audits to the event base SHA and require an explicit full comparison SHA for manual runs. Preserve the new-branch push fallback.
  • Remove unused secret inheritance from the validation-only workflow call.

Type of Change

  • Bug fix

Testing

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 9, 2026 6:06pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the revised event gating and audit-base resolution preserve existing push behavior while correctly covering same-repository stacked pull requests.

Summary

  • Removes the pull-request branch trigger filter and applies explicit job-level gating for primary branches, same-repository stacks, and fork coverage.
  • Uses the event base SHA for pull requests, the event predecessor for pushes, and a required explicit SHA for manual runs.
  • Validates and resolves comparison commits before running block-registry and migration audits.
  • Removes unused secret inheritance from the reusable validation workflow.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  E[Workflow event] --> T{Event type}
  T -->|Pull request| P[Use event base SHA]
  T -->|Manual dispatch| M[Use comparison_base input]
  T -->|Push with predecessor| B[Use event before SHA]
  T -->|New branch push| N[Use HEAD~1]
  P --> V[Require full 40-character SHA]
  M --> V
  B --> V
  N --> V
  V --> F[Fetch and resolve commit]
  F --> A[Run block-registry and migration audits]
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant