Skip to content

fix(landing): stabilize mobile feature graphic sizing - #7649

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/fix-mobile-feature-graphics
Sep 9, 2026
Merged

fix(landing): stabilize mobile feature graphic sizing#7649
waleedlatif1 merged 2 commits into
stagingfrom
codex/fix-mobile-feature-graphics

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace trigonometric CSS scaling in the workflow and file-folder previews with the existing responsive design stage.
  • Preserve the illustration geometry, folder animations, and bottom anchoring, including the transform fallback for browsers without CSS zoom.

Type of Change

  • Bug fix

Testing

  • Manually checked responsive sizing at 320, 390, 768, 1024, and 1280px, light/dark themes, horizontal scrolling, and folder keyboard controls. Physical iPhone verification remains outstanding.
  • 20 focused tests covering uncapped upscaling and the CSS zoom/transform paths, type checking, repository lint, all 46 audits, block-registry validation, and docs-manifest validation passed.
  • Local production build intentionally not run.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 9, 2026 6:02am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with only a non-blocking gap in automated coverage for its newly introduced uncapped responsive-stage configuration.

Findings

  1. P2 Uncapped Scaling Lacks Coverage

Summary

  • Migrates the file-folder preview to a bottom-aligned 350×340 responsive stage.
  • Migrates the workflow preview to a centered 280×400 responsive stage.
  • Retains folder interactions, animations, accessibility attributes, overflow behavior, and the non-zoom transform fallback.
  • The implementation appears behaviorally sound, but the newly introduced uncapped scaling mode lacks focused automated coverage.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Feature graphic container] --> B[ResponsiveDesignStage measures available space]
  B --> C["scale = min(width ratio, height ratio)"]
  C --> D{CSS zoom supported?}
  D -->|Yes| E[Apply finite zoom]
  D -->|No| F[Apply transform scale fallback]
  E --> G[Render fixed-size design surface]
  F --> G
  G --> H[Workflow: centered 280×400 canvas]
  G --> I[Folders: bottom-aligned 350×340 scene]
Loading

@waleedlatif1
waleedlatif1 merged commit ef1e604 into staging Sep 9, 2026
32 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-mobile-feature-graphics branch September 9, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant