feat(files): improve editor recovery and editing controls by waleedlatif1 · Pull Request #7519 · simstudioai/sim

waleedlatif1 · 2026-09-05T16:55:50Z

Summary

Preserve unacknowledged collaborative edits across reconnects and reloads with bounded browser recovery, generation fencing, and atomic Redis replay/compaction. Keep routine reconnection quiet, without draft download/discard controls.
Reconcile external file changes through the transactional outbox, reject stale invalidations, authorize document-room membership before exposing frames, and drain accepted edits during shutdown.
Improve find/replace, link editing, image metadata/resizing, input rules, upload anchors, and editor lifecycle handling. Use the shared floating image toolbar and guard unfinished actions against incompatible peer changes.
Commit collaborative snapshots and Markdown pointers atomically under the existing file-row lock. Check content versions and exact cached revisions, bound snapshot sizes, and make concurrent seeds adopt one accepted identity.
Preserve native snapshots instead of privately normalizing their shared tree. Equivalent external Markdown bodies no longer delete live/offline edit targets. Keep the relay as snapshot owner for compatibility with older caches.
Close review gaps in post-append generation checks, accepted seed identities, missing-file admission, seed cancellation, malformed recovery entries, HTTP response cleanup, preview selection copying, and table-image detection.
Keep compaction off the durable-append acknowledgement wait, recheck current access before and after content-room admission, preserve valueless image attributes, and strengthen pending-delta recovery coverage.
Known limits remain: nested-list reparenting can lose delayed peer edits; unifying all cache-only historical operations needs a legacy compatibility plan; a literal bang immediately before a text link remains ambiguous in the upstream serializer. No unsafe schema migration, dependency patch, or history-reset fallback is included.
Deployment prerequisite: deploy compatible app outbox consumers and realtime relays and drain old consumers before enabling reconciliation producers. Drain older unconditional cache writers before relying on the new revision protocol. Deployment readiness is not verified here.

Type of Change

Bug fix
Enhancement

Testing

After reconciling staging: 379 realtime tests, 2,495 focused app tests, and 13 protocol tests passed; one environment-gated app integration test was skipped. The selection covers 175 passing files, not the entire application suite.
Isolated real Redis with two production store replicas: large pastes, byte-triggered compaction, alternating small edits, and exact fresh replay passed. The merged store preserves staging's byte threshold and cooldown with constant-space prefix accounting and generation-fenced snapshot/trim.
Real PostgreSQL checks exercise cache CAS, competing transactions, rollback, no-op validation, and byte bounds. Separate actual-Yjs tests cover seed races, legacy normalization compatibility, delayed edits, and equivalent-body updates.
Live two-tab editing, peer convergence, reloads, and downloaded durable-file bytes. The live pass exposed a legacy-cache regression in an intermediate implementation; the incompatible history-union change was removed and the same document saved successfully afterward.
All 26 workspace TypeScript checks, repository lint, 45 CI audits, block-registry validation, generated-artifact checks, and the previously completed eight scoped cleanup passes. React Doctor's supplemental full-repository scan was incomplete because its maintainability checks and score service did not complete.
Local tests are not proof of zero possible regressions. Every browser/device, native IME hardware, production session expiry, production failover, and historical-cache migration were not exercised.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new lint or type-check warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-05T16:55:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 7, 2026 11:40pm UTC

waleedlatif1 · 2026-09-05T16:56:43Z

@greptile

waleedlatif1 · 2026-09-05T16:56:44Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-05T16:56:49Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

greptile-apps · 2026-09-05T17:02:01Z

Greptile Summary

This PR strengthens collaborative file editing and recovery across the browser, application, realtime relay, Redis, and durable storage layers.

Preserves bounded pending edits across reconnects and reloads with generation-fenced acknowledgement and replay.
Reconciles external file changes through transactional outbox processing and version-aware invalidation.
Tightens document-room authorization, shutdown draining, snapshot persistence, seeding, and compaction.
Improves rich Markdown editing behavior for find/replace, links, images, input rules, uploads, and editor lifecycle.
The changes since the previous review replace untyped Redis test scaffolding with scoped interfaces, resolving the remaining rule violation without changing runtime behavior.

Confidence Score: 5/5

The PR appears safe to merge because all previous findings are resolved and the latest changes introduce no new actionable issue.

The latest revision only replaces untyped Redis test-client scaffolding with scoped interfaces and shared stream-entry types. The current code also reflects the fixes or accepted resolutions recorded in every previous thread, leaving no outstanding merge blocker.

Important Files Changed

Filename	Overview
apps/realtime/src/handlers/file-doc-store.ts	Adds generation-fenced Redis replay, append, invalidation, seeding, and compaction behavior with bounded resource use.
apps/realtime/src/handlers/file-doc.ts	Strengthens collaborative-room admission, authorization revalidation, synchronization, and invalidation handling.
apps/realtime/src/handlers/file-doc-store.test.ts	Expands Redis stream race and recovery coverage and replaces the previously flagged `any` annotations with scoped test interfaces.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/collaboration/file-doc-provider.ts	Adds acknowledged-update recovery and compatibility handling for disconnected and legacy collaborative sessions.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/collaboration/pending-update-journal.ts	Implements bounded, validated browser recovery records with malformed-entry quarantine.
apps/sim/lib/collab-doc/persist.ts	Coordinates durable collaborative snapshots and Markdown pointers under transactional version checks.
packages/realtime-protocol/src/file-doc.ts	Extends the shared collaboration protocol used by the browser and realtime relay.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Editor[Rich Markdown editor] --> Journal[Bounded pending-update journal]
  Journal --> Provider[File document provider]
  Provider <--> Protocol[Realtime protocol]
  Protocol <--> Relay[Realtime file-document handler]
  Relay <--> Redis[(Generation-fenced Redis stream)]
  Relay --> App[Application seed and reconciliation APIs]
  App --> Outbox[Transactional outbox]
  App --> Database[(Durable file and snapshot state)]

_{Reviews (17): Last reviewed commit: "chore(files): type the Redis test client" | Re-trigger Greptile}

waleedlatif1 · 2026-09-05T17:56:47Z

@cubic-dev-ai review this PR

waleedlatif1 · 2026-09-05T17:56:47Z

@greptile

cubic-dev-ai · 2026-09-05T17:56:52Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-05T18:22:49Z

@greptile

waleedlatif1 · 2026-09-05T18:22:50Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-05T18:22:55Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-05T18:48:31Z

@greptile

waleedlatif1 · 2026-09-05T18:48:32Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-05T18:48:38Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-05T19:50:20Z

@greptile

waleedlatif1 · 2026-09-05T19:50:20Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-05T19:50:26Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-05T20:05:45Z

@greptile

waleedlatif1 · 2026-09-05T20:05:46Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-05T20:05:51Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 81 files

_{Re-trigger cubic}

waleedlatif1 · 2026-09-07T21:55:19Z

@greptile

waleedlatif1 · 2026-09-07T21:55:20Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-07T21:55:26Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 84 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-07T22:18:58Z

@greptile

waleedlatif1 · 2026-09-07T22:18:59Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-07T22:19:05Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-07T22:31:38Z

@greptile

waleedlatif1 · 2026-09-07T22:31:39Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-07T22:31:45Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-09-07T23:23:29Z

@greptile

waleedlatif1 · 2026-09-07T23:32:09Z

@greptile Please re-review the actual PR diff against staging. The table-event concern may be valid upstream, but apps/sim/lib/realtime/event-log.ts and apps/sim/lib/table/events.ts are unchanged from the current staging merge base and are absent from GitHub's complete 84-file PR diff. git diff origin/staging...HEAD -- for those paths is empty. Their byte-budget implementation entered staging through #7568 (commit a69f416), not through this PR.

The last commit merged staging to resolve overlapping file-document compaction changes. Only apps/realtime/src/handlers/file-doc-store.ts and its tests required manual reconciliation. The billing and other Redis changes mentioned in the latest summary are unchanged upstream content carried by that merge, not additions in this PR's base-relative diff.

We have not fixed or claimed a hard per-entry table-event bound here. Please assess the editor PR against its staging base rather than attributing the merge's first-parent upstream changes to it. The file-document resolution retains the byte trigger, cooldown and compaction marker alongside bounded replay, constant-space prefix accounting and generation-fenced atomic snapshot/trim; focused tests and a two-replica real Redis probe passed.

waleedlatif1 · 2026-09-07T23:40:45Z

@greptile

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview September 5, 2026 17:55 Inactive

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview September 5, 2026 18:22 Inactive

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread ...ace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.tsx

vercel Bot temporarily deployed to Preview September 5, 2026 18:48 Inactive

vercel Bot temporarily deployed to Preview September 5, 2026 19:50 Inactive

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread .../sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/image.tsx Outdated

vercel Bot temporarily deployed to Preview September 5, 2026 20:05 Inactive

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/components/find-bar/find-bar.tsx Outdated

vercel Bot deployed to Preview September 7, 2026 21:12 View deployment

cubic-dev-ai Bot reviewed Sep 7, 2026

View reviewed changes

fix(files): close recovery and seed review gaps

0ca4588

vercel Bot temporarily deployed to Preview September 7, 2026 21:54 Inactive

cubic-dev-ai Bot reviewed Sep 7, 2026

View reviewed changes

fix(files): keep acknowledgements responsive and fence admission

75544e3

vercel Bot temporarily deployed to Preview September 7, 2026 22:18 Inactive

greptile-apps Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread apps/realtime/src/handlers/file-doc.ts Outdated

fix(files): recheck access after content-room admission

8d6939c

vercel Bot temporarily deployed to Preview September 7, 2026 22:31 Inactive

fix(files): reconcile staging stream compaction safeguards

36c35e3

vercel Bot temporarily deployed to Preview September 7, 2026 23:23 Inactive

greptile-apps Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread apps/realtime/src/handlers/file-doc-store.test.ts Outdated

chore(files): type the Redis test client

ef49113

vercel Bot temporarily deployed to Preview September 7, 2026 23:40 Inactive

waleedlatif1 merged commit ea3f6ba into staging Sep 8, 2026
30 checks passed

waleedlatif1 deleted the codex/state-of-the-art-file-editor branch September 8, 2026 00:04

waleedlatif1 mentioned this pull request Sep 8, 2026

v0.8.25: Sim Search, SCIM, Sim OAuth #7594

Merged

Uh oh!

Conversation

waleedlatif1 commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 5, 2026

Uh oh!

greptile-apps Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 5, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 5, 2026

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 5, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

waleedlatif1 commented Sep 5, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 5, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 7, 2026

Uh oh!

waleedlatif1 commented Sep 5, 2026 •

edited

Loading

vercel Bot commented Sep 5, 2026 •

edited

Loading

greptile-apps Bot commented Sep 5, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading