fix(credentials): hide gated service accounts from connected list - #6898
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit e479efb. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR filters preview-gated service-account credentials from the user-facing connected-credentials list while preserving direct credential lookup behavior.
Confidence Score: 5/5The PR appears safe to merge, with no actionable correctness or security defects identified. The connected-list path filters only mapped service-account providers, preserves ungated credentials and direct lookups, and avoids unnecessary visibility resolution when no gated provider is present.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/credentials/application/credential-crud.ts | Adds a targeted, viewer-aware visibility filter for gated service-account credentials without changing direct lookup behavior. |
| apps/sim/app/api/credentials/route.test.ts | Adds coverage confirming gated service accounts are hidden and visibility resolution is skipped for unaffected list and lookup paths. |
Reviews (1): Last reviewed commit: "fix(credentials): hide gated service acc..." | Re-trigger Greptile
Summary
Type of Change
Testing
Checklist