improvement(function): secrets access dropdown - #6118
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Secret name loading now uses only the workspace-environment query ( Multi-select value chips use Reviewed by Cursor Bugbot for commit f0959d8. Configure here. |
Greptile SummaryThis PR corrects and improves the Function block’s selected-secret dropdown.
Confidence Score: 5/5The PR appears safe to merge, with no concrete correctness, security, or build failures identified. The workspace environment contract defines workspace secrets as a flat string record, the corrected traversal enumerates that record’s keys, and preserved labels remain compatible with exact-value selection and case-insensitive filtering.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/workflows/subblocks/options.ts | Correctly enumerates workspace secret names from the flat workspace environment record while retaining personal/workspace deduplication. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/dropdown/dropdown.tsx | Adds opt-in case-preserving labels without changing selection identity or case-insensitive search behavior, and adopts the new field chip styling. |
| apps/sim/blocks/blocks/function.ts | Enables case-preserving display specifically for the Function block’s case-sensitive mounted-secret identifiers. |
| apps/sim/blocks/types.ts | Extends SubBlockConfig with the optional dropdown label-case behavior. |
| apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/sub-block.tsx | Propagates the new SubBlockConfig option to the dropdown renderer. |
| packages/emcn/src/components/chip-tag/chip-tag.tsx | Adds a typed field variant whose surface tokens distinguish tags from their containing form field. |
Reviews (1): Last reviewed commit: "improvement(function): secrets access dr..." | Re-trigger Greptile
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f0959d8. Configure here.
Summary
Selected secrets access dropdown UI improvement. Personal v Workspace secrets fix.
Type of Change
Testing
Tested manually
Checklist