Skip to content

fix(settings): add bottom padding to settings sidebar - #6097

Merged
waleedlatif1 merged 1 commit into
stagingfrom
worktree-settings-sidebar-bottom-padding
Jul 30, 2026
Merged

fix(settings): add bottom padding to settings sidebar#6097
waleedlatif1 merged 1 commit into
stagingfrom
worktree-settings-sidebar-bottom-padding

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The settings sidebar's nav list ended flush against the bottom of the sidebar column — the last item had zero bottom gutter (reported by Emir)
  • Root cause: on the settings route the sidebar renders scroll region + nothing after it, while the non-settings branch has a footer block (pt-[9px] pb-2) supplying the bottom gutter. The scroll container's pt-1.5 was copy-pasted from that branch, where the missing pb is fine because the footer follows it
  • Added pb-2 to the settings scroll container, matching the non-settings footer exactly
  • Also normalized the standalone settings shell (account / org / self-host planes) from py-1.5 to pt-1.5 pb-2 — it was 6px, 2px off the workspace sidebar and off its own content pane's p-[8px] inset

Type of Change

  • Bug fix

Testing

Measured the box model in Chromium and WebKit with Playwright: gap from the last nav chip to the sidebar's bottom edge goes 0px -> 8px when the list overflows, and is unchanged (no-op) when it doesn't. Confirmed the padding lands inside the scrollable area (scrollHeight 764 -> 772, clientHeight unchanged) rather than being clipped.

Checked for regressions: neither settings sidebar computes hasOverflowBottom, so no bottom-border/fade state can flip; the hasOverflowBottom logic in sidebar.tsx is bound to the untouched non-settings container. No CSS selector targets these containers' padding. The desktop hover-peek card renders this component with isCollapsed=false and stretches rather than being fixed-height, so the padding adds scrollable space instead of clipping — it now clears the card's rounded-lg bottom corners. No tests or snapshots reference these classNames.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 30, 2026 6:40pm

Request Review

@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Tailwind padding-only changes on settings sidebar layout; no logic, auth, or data handling.

Overview
Fixes the settings nav list sitting flush against the bottom of the sidebar when the list scrolls.

The workspace settings sidebar scroll region now includes pb-2 on its flex scroll container (it previously only had top padding). On the main workspace sidebar, bottom spacing comes from a footer block below the scroll area; the settings route has no footer, so the last nav chip had no bottom gutter.

The standalone settings shell (components/settings/settings-sidebar.tsx) is aligned the same way: py-1.5 becomes pt-1.5 pb-2 so bottom inset matches the workspace settings sidebar and the non-settings footer’s pb-2.

Reviewed by Cursor Bugbot for commit 631492b. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds consistent bottom spacing to settings navigation:

  • Adds an 8px bottom gutter to the workspace settings sidebar scroll region.
  • Adjusts the standalone settings sidebar from 6px to 8px bottom padding while preserving its 6px top padding.

Confidence Score: 5/5

The PR appears safe to merge because the changes are limited to valid padding utilities and no functional regression was identified.

The added padding remains inside the existing overflow containers, does not alter their fixed dimensions or top-overflow calculations, and is not overridden by the class-merging behavior.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-sidebar/settings-sidebar.tsx Adds bottom padding inside the workspace settings scroll container without disrupting its sizing or overflow-state logic.
apps/sim/components/settings/settings-sidebar.tsx Normalizes standalone settings sidebar padding to a 6px top and 8px bottom inset using valid Tailwind utilities.

Reviews (1): Last reviewed commit: "fix(settings): add bottom padding to set..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit d95127d into staging Jul 30, 2026
21 checks passed
@waleedlatif1
waleedlatif1 deleted the worktree-settings-sidebar-bottom-padding branch July 30, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant