fix(settings): add bottom padding to settings sidebar - #6097
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The workspace settings sidebar scroll region now includes The standalone settings shell ( Reviewed by Cursor Bugbot for commit 631492b. Configure here. |
Greptile SummaryAdds consistent bottom spacing to settings navigation:
Confidence Score: 5/5The PR appears safe to merge because the changes are limited to valid padding utilities and no functional regression was identified. The added padding remains inside the existing overflow containers, does not alter their fixed dimensions or top-overflow calculations, and is not overridden by the class-merging behavior.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/settings-sidebar/settings-sidebar.tsx | Adds bottom padding inside the workspace settings scroll container without disrupting its sizing or overflow-state logic. |
| apps/sim/components/settings/settings-sidebar.tsx | Normalizes standalone settings sidebar padding to a 6px top and 8px bottom inset using valid Tailwind utilities. |
Reviews (1): Last reviewed commit: "fix(settings): add bottom padding to set..." | Re-trigger Greptile
Summary
pt-[9px] pb-2) supplying the bottom gutter. The scroll container'spt-1.5was copy-pasted from that branch, where the missingpbis fine because the footer follows itpb-2to the settings scroll container, matching the non-settings footer exactlypy-1.5topt-1.5 pb-2— it was 6px, 2px off the workspace sidebar and off its own content pane'sp-[8px]insetType of Change
Testing
Measured the box model in Chromium and WebKit with Playwright: gap from the last nav chip to the sidebar's bottom edge goes 0px -> 8px when the list overflows, and is unchanged (no-op) when it doesn't. Confirmed the padding lands inside the scrollable area (
scrollHeight764 -> 772,clientHeightunchanged) rather than being clipped.Checked for regressions: neither settings sidebar computes
hasOverflowBottom, so no bottom-border/fade state can flip; thehasOverflowBottomlogic insidebar.tsxis bound to the untouched non-settings container. No CSS selector targets these containers' padding. The desktop hover-peek card renders this component withisCollapsed=falseand stretches rather than being fixed-height, so the padding adds scrollable space instead of clipping — it now clears the card'srounded-lgbottom corners. No tests or snapshots reference these classNames.Checklist