feat(skills): canonicalize skills to a single source with generated .claude/.cursor projections#5609
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview
New skills/commands document operational workflows: Integration builder docs are aligned across add/validate skills: no guessed API/webhook/tool outputs; blocks register in Connector/trigger docs add Reviewed by Cursor Bugbot for commit 183a605. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR updates the cleanup skill and skill command projection flow. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (11): Last reviewed commit: "Merge remote-tracking branch 'origin/sta..." | Re-trigger Greptile |
…ing skills into .claude/commands
…ead of literal <scope>
|
@cursor review |
…rough convergence for ordered apply
|
@cursor review |
…e when a prior pass invalidated the snippet
|
@cursor review |
|
@cursor review |
…mbiguate babysit /ship refs in claude copy
|
@cursor review |
|
@cursor review |
… .claude/.cursor projections Establish .agents/skills/<name>/SKILL.md as the single source of truth (latest content reconciled per skill from the three drifted copies), and generate the .claude/commands and .cursor/commands projections from it via scripts/sync-skills.ts. Adds skills:sync/skills:check, a CI gate, a pre-commit regen hook, and CONTRIBUTING docs. Structurally fixes prior drift (e.g. abbreviated .claude ship -> full ship).
…ck has no per-file target Removes stray </content>/</invoke> markup that leaked into add-block, add-connector, add-hosted-key canonical skills, and reword the cleanup skill's lint step to note bun run lint:check runs repo-wide via turbo (no per-path API). Projections regenerated via skills:sync. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QjefwescJoHZ6zcc3C17FR
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit dfb6c34. Configure here.
Re-add the "if any tool outputs are still unknown, tell the user instead of guessing block outputs" step that was dropped when Final Validation step 5 became the BlockMeta template check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QjefwescJoHZ6zcc3C17FR
|
@cursor review |
…nup-skill # Conflicts: # .claude/commands/cleanup.md # .claude/commands/ship.md
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 183a605. Configure here.
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 183a605. Configure here.
Summary
Establishes a single source of truth for the repo's agent skills and eliminates the three-copy drift that had accumulated across
.agents/skills,.claude/commands, and.cursor/commands..agents/skills/<name>/SKILL.md(frontmattername+description+ optionalargument-hint, then body)..claude/commands/<name>.mdand.cursor/commands/<name>.mdare generated from it byscripts/sync-skills.ts— never hand-edited.bun run skills:syncregenerates;bun run skills:checkfails on any stale projection and is wired into CI (test-build.yml); a pre-commit hook auto-regenerates when aSKILL.mdis staged.CONTRIBUTING.mddocuments "edit canonical only."listingCapped,registry-maps.ts) was verified still live before restoring guidance. Stale-and-wrong instructions were corrected (e.g. the old "don't add tags to BlockConfig" rule, now the opposite in current code)./cleanupoverhaul (the original seed of this PR): rewritten from sequential to parallel read-only analysis → converge → sequential pass-ordered apply, avoiding concurrent-write clobbering while keeping the analysis speedup. Adds a new comment-reduction pass (you-might-not-need-a-comment) and wiresyou-might-not-need-url-stateinto the set (8 passes total)..claude/commands/ship.mdis now the full ship; Cursor gained the 8 skills it was missing; babysit's/shipreferences now point at the canonical source.Type of Change
Testing
bun run skills:checkpasses; all three trees hold the same 31 skills with no orphans.agents/skillsis tracked (not gitignored) so the CI gate runs on a fresh checkoutskills:syncis a no-op); biome-cleanChecklist