-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(ux): more explicit verbiage on some dialog menus, google drive updates, advanved to additional fields, remove general settings store sync in favor of tanstack #2875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,821
−1,046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive updates, advanved to additional fields, remove general settings store sync in favor of tanstack
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThis PR makes several UX improvements and removes an architectural antipattern: Store Refactor
Google Drive Updates
Advanced to Additional Fields
Nested Tag Dropdown
Dialog Verbiage
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Component as React Component
participant TanStack as TanStack Query
participant API as Settings API
participant Zustand as Zustand Store (REMOVED)
Note over Component,Zustand: BEFORE: Antipattern with dual state
Component->>TanStack: useGeneralSettings()
TanStack->>API: fetchGeneralSettings()
API-->>TanStack: settings data
TanStack->>Zustand: syncSettingsToZustand()
Note over Zustand: Duplicate state!
TanStack-->>Component: settings
Component->>Zustand: useGeneralStore()
Zustand-->>Component: settings (duplicate)
Note over Component,API: AFTER: Single source of truth
Component->>TanStack: useAutoConnect()
TanStack->>API: fetchGeneralSettings()
API-->>TanStack: settings data
TanStack-->>Component: autoConnect value
Note over Component: No Zustand sync!
Note over Component,TanStack: Mutation flow (optimistic updates)
Component->>TanStack: useUpdateGeneralSetting()
TanStack->>TanStack: Optimistically update cache
TanStack->>API: PATCH /settings
alt Success
API-->>TanStack: 200 OK
TanStack->>TanStack: Confirm cache update
else Error
API-->>TanStack: Error
TanStack->>TanStack: Rollback to previous cache
end
TanStack-->>Component: Updated settings
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
30 files reviewed, 1 comment
…or context menus, etc
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
show additional fieldscontingent on the tool chosen atm, rather than at the block-levelType of Change
Testing
Manually
Checklist