Expose Apache Ossie across public workflows - #331
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3093e7b008
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| adapter = OssieAdapter( | ||
| target_dialect=layer.dialect or "duckdb", | ||
| consumer_profile=consumer_profile, | ||
| scope_id=ossie_scope_id, |
There was a problem hiding this comment.
When an auto-discovered directory contains multiple one-scope Ossie files, this creates and parses an adapter separately for each file, after which the generic loader merges their graphs with _merge_models. That bypasses OssieAdapter.parse_catalog(directory), so isolated namespaces are flattened and a same-named dataset becomes last-writer-wins; supplying --ossie-scope is also applied to every file independently and fails as soon as a document lacks that scope. Collect the detected documents into one qualified catalog before resolving the requested scope.
AGENTS.md reference: AGENTS.md:L7-L9
Useful? React with 👍 / 👎.
| use_preaggregations: bool = False, | ||
| engine: str | None = None, | ||
| fallback: bool | None = None, | ||
| ossie_scope: str | None = None, |
There was a problem hiding this comment.
For a multi-scope Ossie document, the canonical adapter raises an ambiguity error unless this new helper argument is supplied. I checked the rewrite and explain_sql_command call sites: neither command exposes --ossie-scope nor passes a value here, so these public query-planning workflows cannot use a supported multi-scope source even though query can. Add and thread the selector through both commands.
AGENTS.md reference: AGENTS.md:L7-L9
Useful? React with 👍 / 👎.
| if ossie_permissive: | ||
| source_adapter_options["import_policy"] = "permissive" |
There was a problem hiding this comment.
When --ossie-permissive is used on the invalid input it is intended for, this option reaches OssieAdapter.parse(), which still unconditionally raises whenever any lowering has valid == False. Consequently the conversion never returns the independently safe constructs or a preserved document, while valid inputs behave identically to strict mode. Route this mode through the document/catalog migration API, or reject/remove the CLI option rather than advertising behavior it cannot provide.
AGENTS.md reference: AGENTS.md:L7-L9
Useful? React with 👍 / 👎.
1 participant
Stack created with GitHub Stacks CLI • Give Feedback 💬