Use async versions of bcrypt methods to avoid freezing browser tab#204
Merged
sharevb merged 4 commits intosharevb:chore/all-my-stuffsfrom Nov 12, 2025
Merged
Conversation
Owner
|
Hi @lionel-rowe many thanks for this PR now merged |
sharevb
added a commit
that referenced
this pull request
Nov 12, 2025
sharevb
added a commit
that referenced
this pull request
Nov 12, 2025
sharevb
added a commit
that referenced
this pull request
Nov 12, 2025
sharevb
added a commit
that referenced
this pull request
Nov 12, 2025
sharevb
added a commit
that referenced
this pull request
Nov 12, 2025
sharevb
added a commit
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as CorentinTh#1152:
With the following changes:
Intl.DurationFormat.Intl.DurationFormatas it's only baseline March 2025.bcryptjsto 3.0.3, which includes fix: Always yield to event loop before nextTick for async versions dcodeIO/bcrypt.js#164. Older versions conditionally useprocess.nextTickfor scheduling if it's available butsetImmediateisn't, which means the event loop isn't yielded to and so the browser tab can still easily be crashed; and due to node polyfills in use, that condition was now being hit (whereas it wasn't in theCorentinTh/it-toolsPR).bcrypt.jswill automatically set it to a minimum of 4 anyway.I didn't add polyfills for
AbortSignal.anyorAbortSignal.timeout, which are both baseline March 2024.UI/interactions look like this:
