Skip to content

fix: sanitize subprocess call in init_agent.py #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix: sanitize subprocess call in init_agent.py #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions skills/agent-builder/scripts/init_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from anthropic import Anthropic
from dotenv import load_dotenv
import subprocess
import shlex
import os

load_dotenv()
Expand Down Expand Up @@ -63,7 +64,7 @@ def run(prompt, history=[]):
if b.type == "tool_use":
print(f"> {{b.input['command']}}")
try:
out = subprocess.run(b.input["command"], shell=True, capture_output=True, text=True, timeout=60)
out = subprocess.run(shlex.split(b.input["command"]), shell=False, capture_output=True, text=True, timeout=60)
output = (out.stdout + out.stderr).strip() or "(empty)"
except Exception as e:
output = f"Error: {{e}}"
Expand All @@ -89,6 +90,7 @@ def run(prompt, history=[]):
from dotenv import load_dotenv
from pathlib import Path
import subprocess
import shlex
import os

load_dotenv()
Expand Down Expand Up @@ -133,7 +135,7 @@ def execute(name: str, args: dict) -> str:
if any(d in args["command"] for d in dangerous):
return "Error: Dangerous command blocked"
try:
r = subprocess.run(args["command"], shell=True, cwd=WORKDIR, capture_output=True, text=True, timeout=60)
r = subprocess.run(shlex.split(args["command"]), shell=False, cwd=WORKDIR, capture_output=True, text=True, timeout=60)
return (r.stdout + r.stderr).strip()[:50000] or "(empty)"
except subprocess.TimeoutExpired:
return "Error: Timeout (60s)"
Expand Down