Playwright Setup by kumaradityaraj · Pull Request #60 · serverlessworkflow/editor

kumaradityaraj · 2026-04-13T06:59:22Z

Close Set up Playwright end-to-end testing

For testing :-

Navigate to the package
run pnpm test-e2e or pnpm test-e2e:ui

Updated version of Setup:-

The tests has been shifted in the package itself within tests-e2e directory.
For e2e tests the file name must be named in this particular regex- fileName.e2e.ts
Make sure in playwright.config.ts you set the above file structure for playwright to recognise it else it fails to start because vite tests are also present in the same directory.
testDir: "./tests-e2e", testMatch: "**/*.e2e.ts"
For CI, Playwright gets installed in the starting itself at the time of building which can be seen in base package.json

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a Playwright-based E2E testing package to the monorepo and includes an initial test validating the Diagram Editor Storybook render.

Changes:

Introduces a new @serverlessworkflow/playwright workspace package with Playwright config and scripts.
Adds an initial E2E spec for the Diagram Editor (Storybook iframe route).
Ignores Playwright output artifacts in .gitignore.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
packages/playwright/tests/diagram-editor.spec.ts	Adds an initial E2E test against the Diagram Editor Storybook iframe.
packages/playwright/playwright.config.ts	Configures Playwright base URL and webServer startup for local runs.
packages/playwright/package.json	Adds a new workspace package with Playwright dev dependency and scripts.
packages/playwright/README.md	Documents how to run the Playwright tests in the monorepo.
.gitignore	Ignores Playwright reports/results directories.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

kumaradityaraj · 2026-04-13T07:18:38Z

@fantonangeli @lornakelly @handreyrc Please review this PR. Thank you.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 11 changed files in this pull request and generated 7 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

kumaradityaraj · 2026-04-14T10:28:05Z

@fantonangeli @lornakelly @handreyrc Please review this PR.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated 6 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>

…t-id Fix comment: https://github.com/serverlessworkflow/editor/pull/60#dis…

Copilot

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

kumaradityaraj · 2026-04-16T08:53:39Z

@fantonangeli @lornakelly @handreyrc i think its ready for the final review.

fantonangeli · 2026-04-16T08:59:47Z

@kumaradityaraj would you mind a last try with this: https://github.com/serverlessworkflow/editor/pull/60/changes#r3091910499 ?

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

kumaradityaraj · 2026-04-16T09:10:48Z

@kumaradityaraj would you mind a last try with this: https://github.com/serverlessworkflow/editor/pull/60/changes#r3091910499 ?

Interesting it works now

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

kumaradityaraj added 2 commits April 13, 2026 12:23

PlaywrightSetup

ab9ca79

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Syncing upstream

aaff34b

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI review requested due to automatic review settings April 13, 2026 06:59

Copilot started reviewing on behalf of kumaradityaraj April 13, 2026 06:59 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread packages/playwright/package.json Outdated

Comment thread packages/playwright/playwright.config.ts

Comment thread packages/playwright/playwright.config.ts Outdated

Comment thread packages/playwright/tests/diagram-editor.spec.ts

Comment thread packages/playwright/README.md Outdated

Copilots suggestions

73947d8

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

kumaradityaraj requested review from fantonangeli, handreyrc and lornakelly April 13, 2026 07:21

shifting playwright in package itself

2ce68a6

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI review requested due to automatic review settings April 14, 2026 09:05

Copilot started reviewing on behalf of kumaradityaraj April 14, 2026 09:05 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

kumaradityaraj added 2 commits April 14, 2026 14:41

shifting playwright in package itself

6711115

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Installing playwright in ci and playwright as catalog

d3c1db3

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI review requested due to automatic review settings April 14, 2026 09:20

Copilot started reviewing on behalf of kumaradityaraj April 14, 2026 09:21 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread packages/serverless-workflow-diagram-editor/tests/e2e/diagram-editor.e2e.ts Outdated

Comment thread packages/serverless-workflow-diagram-editor/package.json Outdated

Comment thread .github/workflows/ci_build.yaml Outdated

kumaradityaraj added 2 commits April 14, 2026 14:55

resolving playwright installation

114c17e

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

resolving playwright installation

50414a3

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI review requested due to automatic review settings April 14, 2026 09:29

Copilot started reviewing on behalf of kumaradityaraj April 14, 2026 09:30 View session

removing playwright from ci

d2f98b3

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Fixing CI for playwright

d2546ee

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Resolving merge conflict

5f9f232

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI review requested due to automatic review settings April 15, 2026 07:46

Copilot started reviewing on behalf of kumaradityaraj April 15, 2026 07:46 View session

Copilot started reviewing on behalf of kumaradityaraj April 15, 2026 11:24 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

kumaradityaraj force-pushed the playwright branch from 9c8fc26 to 1397a55 Compare April 15, 2026 11:56

Copilot AI review requested due to automatic review settings April 15, 2026 11:56

Copilot started reviewing on behalf of kumaradityaraj April 15, 2026 11:57 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread pnpm-lock.yaml

kumaradityaraj force-pushed the playwright branch from 1397a55 to d9dd92d Compare April 15, 2026 12:00

adding playwright artifact in CI

42ae822

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI review requested due to automatic review settings April 15, 2026 12:03

Copilot started reviewing on behalf of kumaradityaraj April 15, 2026 12:03 View session

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Comment thread packages/serverless-workflow-diagram-editor/playwright.config.ts

Comment thread pnpm-lock.yaml

kumaradityaraj and others added 2 commits April 16, 2026 13:23

Refix fab comments for title

96bf196

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Fix comment: serverlessworkflow#60 (comment)

914682a

Signed-off-by: fantonangeli <fabrizio.antonangeli@gmail.com>

fantonangeli mentioned this pull request Apr 16, 2026

Fix comment: https://github.com/serverlessworkflow/editor/pull/60#dis… kumaradityaraj/editor#1

Merged

Merge pull request #1 from fantonangeli/kumaradityaraj-playwright-tes…

4c477f5

…t-id Fix comment: https://github.com/serverlessworkflow/editor/pull/60#dis…

Copilot AI review requested due to automatic review settings April 16, 2026 08:26

Copilot started reviewing on behalf of kumaradityaraj April 16, 2026 08:27 View session

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread packages/serverless-workflow-diagram-editor/vitest.config.ts Outdated

Comment thread packages/serverless-workflow-diagram-editor/playwright.config.ts

Comment thread package.json

Comment thread pnpm-lock.yaml

kumaradityaraj added 2 commits April 16, 2026 14:13

small fix

919ef93

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Signing off

66190a5

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

kumaradityaraj requested a review from fantonangeli April 16, 2026 08:55

CI testing

87ba61a

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI review requested due to automatic review settings April 16, 2026 09:07

Copilot started reviewing on behalf of kumaradityaraj April 16, 2026 09:07 View session

Testing package.json

b1c8e89

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread packages/serverless-workflow-diagram-editor/tests-e2e/diagram-editor.spec.ts

Comment thread packages/serverless-workflow-diagram-editor/stories/DiagramEditor.stories.ts

Testing package.json

37496a7

Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>

Conversation

kumaradityaraj commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kumaradityaraj commented Apr 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

kumaradityaraj commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kumaradityaraj commented Apr 16, 2026

Uh oh!

fantonangeli commented Apr 16, 2026

Uh oh!

kumaradityaraj commented Apr 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

kumaradityaraj commented Apr 13, 2026 •

edited

Loading