Remove moduleState init from gapbind14 kernel extension#1179
Merged
Conversation
Global variables are zero-initialized anyway, so this makes no difference. Note that module state only matters for HPC-GAP. In the future, I'd like to hide the moduleStateSize and moduleStateOffsetPtr for "regular" GAP builds.
Contributor
Author
|
I can also retarget this at the stable-5.6 branch if you prefer |
Collaborator
|
Thanks happy to have this in main, the ci failures are related to the issue reported by Reinis, and not this pr probably |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global variables are zero-initialized anyway, so this makes no
difference.
Note that module state only matters for HPC-GAP. In the future,
I'd like to hide the moduleStateSize and moduleStateOffsetPtr
for "regular" GAP builds.