Skip to content

Add table_list function#33

Merged
selenil merged 4 commits intoselenil:mainfrom
DynamicCake:feature/table-list
Mar 15, 2026
Merged

Add table_list function#33
selenil merged 4 commits intoselenil:mainfrom
DynamicCake:feature/table-list

Conversation

@DynamicCake
Copy link
Contributor

No description provided.

@DynamicCake
Copy link
Contributor Author

I should add docs tbh

Previously it relied on dict value ordering (big no no)
@selenil
Copy link
Owner

selenil commented Mar 15, 2026

I'm unsure about the behavior of table_list_decoder, maybe it's better to remove it since tables should be decoded to a Dict(Int, a) to preserve the correct order anyway.

@DynamicCake
Copy link
Contributor Author

DynamicCake commented Mar 15, 2026

I'm unsure about the behavior of table_list_decoder

I was slacking on the docs department :P.
I have written a bit more docs to clarify the usage.

maybe it's better to remove it since tables should be decoded to a Dict(Int, a) to preserve the correct order anyway.

From my usage when I want a list from the lua script, I always want it in a list. I think this applies for majority of use cases, but I am willing to be disproven in the beta test.

DynamicCake and others added 2 commits March 14, 2026 21:05
By using glua.table instead of glua.do_table

Co-authored-by: selenil <157198464+selenil@users.noreply.github.com>
@selenil
Copy link
Owner

selenil commented Mar 15, 2026

I have written a bit more docs to clarify the usage.

Now with docs it makes sense, my issue was mostly table_list_decoder being a little surprising when there is a gap in the indexes of the table but I think is worthy for the convenience it adds.

@selenil selenil merged commit 42cabc2 into selenil:main Mar 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants