feat(giga): fallback to v2 for associations and migrations#3103
Open
feat(giga): fallback to v2 for associations and migrations#3103
Conversation
35a8f5e to
439daa1
Compare
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3103 +/- ##
==========================================
+ Coverage 58.73% 58.75% +0.01%
==========================================
Files 2094 2094
Lines 173026 172978 -48
==========================================
+ Hits 101627 101631 +4
+ Misses 62419 62370 -49
+ Partials 8980 8977 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
yzang2019
approved these changes
Mar 20, 2026
stevenlanders
approved these changes
Mar 22, 2026
439daa1 to
ec9b66a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
#2994 introduced an iterator for the cachekv store for the specific purpose of migrating balances during association. There are concerns with that change -- in particular future stores won't support iterators at all.
Instead, we can simply fallback to v2 when associatons need to occur, similar to how we handle interop. This PR makes that change, and adds a test for it.
Testing performed to validate your change