Skip to content

feat(giga): fallback to v2 for associations and migrations#3103

Open
arajasek wants to merge 2 commits intomainfrom
asr/migrate-using-v2
Open

feat(giga): fallback to v2 for associations and migrations#3103
arajasek wants to merge 2 commits intomainfrom
asr/migrate-using-v2

Conversation

@arajasek
Copy link
Contributor

Describe your changes and provide context

#2994 introduced an iterator for the cachekv store for the specific purpose of migrating balances during association. There are concerns with that change -- in particular future stores won't support iterators at all.

Instead, we can simply fallback to v2 when associatons need to occur, similar to how we handle interop. This PR makes that change, and adds a test for it.

Testing performed to validate your change

@github-actions
Copy link

github-actions bot commented Mar 20, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 24, 2026, 9:03 PM

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.75%. Comparing base (7fd79a0) to head (439daa1).

Files with missing lines Patch % Lines
giga/executor/precompiles/failfast.go 50.00% 2 Missing ⚠️
giga/deps/store/cachekv.go 0.00% 1 Missing ⚠️
giga/deps/xbank/keeper/view.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3103      +/-   ##
==========================================
+ Coverage   58.73%   58.75%   +0.01%     
==========================================
  Files        2094     2094              
  Lines      173026   172978      -48     
==========================================
+ Hits       101627   101631       +4     
+ Misses      62419    62370      -49     
+ Partials     8980     8977       -3     
Flag Coverage Δ
sei-chain-pr 57.00% <66.66%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 68.83% <100.00%> (+1.39%) ⬆️
giga/deps/store/cachekv.go 55.55% <0.00%> (+13.53%) ⬆️
giga/deps/xbank/keeper/view.go 91.11% <80.00%> (-1.62%) ⬇️
giga/executor/precompiles/failfast.go 33.33% <50.00%> (+6.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arajasek arajasek added this pull request to the merge queue Mar 23, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 23, 2026
@arajasek arajasek added this pull request to the merge queue Mar 23, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 23, 2026
@arajasek arajasek added this pull request to the merge queue Mar 24, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2026
@arajasek arajasek force-pushed the asr/migrate-using-v2 branch from 439daa1 to ec9b66a Compare March 24, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants