Open
Conversation
🦋 Changeset detectedLatest commit: 7a8da6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
changed the title
silesky
force-pushed
the
refactor-get-cdn
branch
from
df8d60e to
7a8da6e
Compare
danieljackins
approved these changes
Oct 26, 2022
chrisradek
reviewed
Oct 26, 2022
| @@ -79,11 +79,9 @@ export interface AnalyticsBrowserSettings extends AnalyticsSettings { | |||
|
|
|||
| export function loadLegacySettings( | |||
Contributor
There was a problem hiding this comment.
I believe this a breaking change. I have seen some users actually use this function in their own code.
silesky
force-pushed
the
master
branch
2 times, most recently
from
da031b5 to
275d5a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of an OCD fix -- as there are more improvements to be made. However I got rid of some smells, like testing loadLegacySettings in tests.