Feature/hide secrets deploy msi#5
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces enhanced security for logging sensitive parameters by implementing a centralized masking function. The changes prevent exposure of passwords, tokens, and other credentials in console output during MSI installations and test runs.
Key Changes:
- Added
Format-ParameterForLogginghelper function to mask sensitive parameters and connection string secrets - Replaced inline password detection logic with the new centralized masking function
- Added comprehensive test coverage for various sensitive parameter scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| DOrcDeployModule.psm1 | Implements new Format-ParameterForLogging function and refactors InstallMSI and RunMTMTests to use centralized parameter masking |
| DOrcDeployModule.tests.ps1 | Adds test suite covering basic parameter masking, case insensitivity, and connection string security scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…efe/DOrcDeployModule into feature/hide-secrets-DeployMSI
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
introduce better masking of secure properties in output