Skip to content

Feature/hide secrets deploy msi#5

Merged
andrei-salanovich-ext-sefe merged 11 commits intomainfrom
feature/hide-secrets-DeployMSI
Oct 27, 2025
Merged

Feature/hide secrets deploy msi#5
andrei-salanovich-ext-sefe merged 11 commits intomainfrom
feature/hide-secrets-DeployMSI

Conversation

@andrei-salanovich-ext-sefe
Copy link
Collaborator

introduce better masking of secure properties in output

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces enhanced security for logging sensitive parameters by implementing a centralized masking function. The changes prevent exposure of passwords, tokens, and other credentials in console output during MSI installations and test runs.

Key Changes:

  • Added Format-ParameterForLogging helper function to mask sensitive parameters and connection string secrets
  • Replaced inline password detection logic with the new centralized masking function
  • Added comprehensive test coverage for various sensitive parameter scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
DOrcDeployModule.psm1 Implements new Format-ParameterForLogging function and refactors InstallMSI and RunMTMTests to use centralized parameter masking
DOrcDeployModule.tests.ps1 Adds test suite covering basic parameter masking, case insensitivity, and connection string security scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andrei-salanovich-ext-sefe andrei-salanovich-ext-sefe merged commit 0b8111c into main Oct 27, 2025
3 checks passed
@andrei-salanovich-ext-sefe andrei-salanovich-ext-sefe deleted the feature/hide-secrets-DeployMSI branch October 27, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants