Can now specify which 'layer' of the AnnData table to use#402
Merged
Can now specify which 'layer' of the AnnData table to use#402
Conversation
…ing points using a table
Collaborator
Author
|
This PR depends on scverse/spatialdata#818 |
Collaborator
Author
|
Todo:
|
added 2 commits
January 13, 2025 21:29
…/github.com/scverse/spatialdata-plot into feature/issue326-layer-selection-of-anndata
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 83.76% 83.83% +0.06%
==========================================
Files 8 8
Lines 1694 1732 +38
==========================================
+ Hits 1419 1452 +33
- Misses 275 280 +5
|
Collaborator
Author
|
Member
|
@LucaMarconato this PR is waiting for the next |
Member
Yes, today 😁 |
timtreis
approved these changes
Jan 20, 2025
Member
timtreis
left a comment
There was a problem hiding this comment.
Added validation function, otherwise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solve #326
Plus: 2 bugfixes when coloring points by values in a table:
a) coloring by values in table.X didn't work before
b) Error when using the
groupsargument while the values to color by are stored in a table