Improve Xenium performance, fix multinucleate cells bug#376
Merged
LucaMarconato merged 3 commits intomainfrom Feb 25, 2026
Merged
Improve Xenium performance, fix multinucleate cells bug#376LucaMarconato merged 3 commits intomainfrom
LucaMarconato merged 3 commits intomainfrom
Conversation
Replace slow parquet string-based cell_id grouping with zarr polygon_sets for both nucleus and cell boundaries. This fixes a multinucleate cell bug where multiple nuclei sharing the same cell_id were incorrectly merged into a single polygon, and improves performance by avoiding expensive string operations on large parquet columns. Key changes: - Split _get_labels_and_indices_mapping into focused functions: _get_labels, _get_indices_mapping_from_zarr, _get_indices_mapping_legacy - Nucleus boundaries now use integer label_index as GeoDataFrame index (with cell_id as a column), correctly handling multinucleate cells - Cell boundaries keep string cell_id as GeoDataFrame index (legacy) - Read only needed parquet columns for faster I/O - Use integer label_id for fast change detection when available Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 61.80% 61.65% -0.15%
==========================================
Files 27 27
Lines 3155 3161 +6
==========================================
- Hits 1950 1949 -1
- Misses 1205 1212 +7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last commit message is indicative of this PR. Copy-pasting it below.
Refactor xenium polygon reader to use zarr-based indices mapping
Replace slow parquet string-based cell_id grouping with zarr polygon_sets
for both nucleus and cell boundaries. This fixes a multinucleate cell bug
where multiple nuclei sharing the same cell_id were incorrectly merged
into a single polygon, and improves performance by avoiding expensive
string operations on large parquet columns.
Key changes:
_get_labels, _get_indices_mapping_from_zarr, _get_indices_mapping_legacy
(with cell_id as a column), correctly handling multinucleate cells