Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3954 +/- ##
==========================================
- Coverage 78.26% 78.25% -0.01%
==========================================
Files 117 117
Lines 12633 12638 +5
==========================================
+ Hits 9887 9890 +3
- Misses 2746 2748 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ilan-gold
reviewed
Jan 30, 2026
Contributor
ilan-gold
left a comment
There was a problem hiding this comment.
Can you add a release note explaining this a bit? Maybe a link to something like how you discovered this?
Also, it this something we should be doing globally?
Also, what if this crshes before you reset?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a potential bug for regress out where more than 64 threads leads to a hard crash