Add values_to_plot support to matrixplot and heatmap (issue #3842)#3902
Draft
giovanamotta wants to merge 2 commits intoscverse:mainfrom
Draft
Add values_to_plot support to matrixplot and heatmap (issue #3842)#3902giovanamotta wants to merge 2 commits intoscverse:mainfrom
giovanamotta wants to merge 2 commits intoscverse:mainfrom
Conversation
Member
|
Hi, looks like this isn’t finished yet, there are still syntax errors in the code. I can’t review this yet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
values_to_plotsupport forrank_genes_groups_matrixplotandrank_genes_groups_heatmap, addressing issue #3842.I implemented a small wrapper module (
_rank_genes_groups.py) that extracts the selected differential expression metric (scores,logfoldchanges,pvals, orpvals_adj) fromadata.uns['rank_genes_groups']and passes it to MatrixPlot / Heatmap viavalues_df.No changes were required to the plot base classes; the new functions simply reuse the existing engines (
matrixplot,heatmap,dotplot). This keeps the PR minimal and adds full parity with the existing dotplot behavior.