Gracefully shut down the original container#543
Merged
zmiklank merged 2 commits intosclorg:masterfrom Jan 6, 2024
Merged
Conversation
…ume" This reverts commit 62a0e88. Creating a new volume directory was actually NOOP, because the variable volume_options was not updated. What we need to get rid of SELinux messages that this fix tried to address is to properly shut down previous container. That will be done in the following commit. Background: podman's :Z modificator for volumes works the way that the latest container run with the same volume directory mounted with :Z modificator has access, the previous containers are kept running, but access to the shared directory is suddenly removed. That caused the first instance of PostgreSQL server to crash with SIGSEGV actually, while triggering some SELinux error message during that.
With keeping the container running, we see SELinux error messages and sudden crash of the PostgreSQL container. Let's properly shut down the container before using its volume privately mounted into a different container. Background: podman's :Z modificator for volumes works the way that the latest container run with the same volume directory mounted with :Z modificator has access, the previous containers are kept running, but access to the shared directory is suddenly removed. That caused the first instance of PostgreSQL server to crash with SIGSEGV actually, while triggering some SELinux error message during that.
Member
Author
|
[test] |
zmiklank
reviewed
Jan 5, 2024
Contributor
zmiklank
left a comment
zmiklank
left a comment
There was a problem hiding this comment.
Looks good, thanks for the thorough investigation and for great commit messages!
I have just one small note, see in inline comments.
zmiklank
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With keeping the container running, we see SELinux error messages and a sudden crash of the PostgreSQL container. Let's properly shut down the container before using its volume privately mounted into a different container.
This should fix #536 and also reverts previous attempt (#538) to fix the issues with SELinux messages.
Background:
podman's :Z modificator for volumes works the way that the latest container run with the same volume directory mounted with :Z modificator has access, the previous containers are kept running, but access to the shared directory is suddenly removed. That caused the first instance of PostgreSQL server to crash with SIGSEGV actually, while triggering some SELinux error message during that.
Related to #542.