Conversation
|
[test-all] |
phracek
left a comment
There was a problem hiding this comment.
Container tests are passing. Unfortunately, I am not a database expert. @hhorak @fila43 WDYT?
As soon as @fila43 or @hhorak approve this pull request, we can merge it.
@aushacker Do we have a test for it? If not please create at least one.
|
@phracek Have had a look through the available tests, none of them seem to match the required procedure. What is needed to test would be something like:
How does that fit in with the current testing procedure? |
|
I do not see any problem with proposed example |
|
[test-all] |
|
@aushacker Thank you for this pull request. Please do following steps:
|
Pull Request validationFailed🔴 Failed or pending statuses:
Success🟢 Review - Reviewed by a member |
|
@aushacker Can you plesae rebase against the master? We are close to merge it. Thanks [test] |
phracek
left a comment
There was a problem hiding this comment.
LGTM. Thanks for proposed example.
A simple example showing how to configure a database with some test data.
When using ephemeral storage the database name specified by POSTGRESQL_DATABASE must be different from that created in the user provided script, otherwise the container will crash loop. This is due to the default scripts hard failing when trying to create a database that the user supplied init script has already created.
See issue #296 for narrative (known problem).