Bin by pixel #224
Open
Bin by pixel #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Questions that remain answering
|
jl-wynen
reviewed
Jan 19, 2026
Member
jl-wynen
left a comment
jl-wynen
left a comment
There was a problem hiding this comment.
I don not see any pixel binning here, only binning by position. Is the detector aligned with the instrument coord system? And does the mcstas file not contain pixel ids?
| sc.midpoints(da.coords['y']), | ||
| sc.midpoints(-da.coords['x'] if bank == 1 else da.coords['x']), | ||
| ) | ||
| ).transpose(da.dims) |
Member
There was a problem hiding this comment.
Can you add a comment explaining what is going on here?
Why are you using 'x' as the z component of the vector? (You should drop the 'x' coord to avoid confusions down the line.)
| da.coords['Ltotal'] = L1 + L2 | ||
| da.coords['two_theta'] = sc.acos( | ||
| (-da.coords['x'] if bank == 1 else da.coords['x']) / L2 | ||
| (da.coords['position'] - da.coords['sample_position']).fields.z / L2 |
Member
There was a problem hiding this comment.
This doesn't look right because it doesn't account for the source position. Why don't you us tuse the predefined coord transform graph?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #217 by binning the McStas data by "pixel" after loading and adapting the workflow to handle the pixel-binned data structure.