Conversation
|
Hi @nex3 , please take a look at the changes that were necessary to fix the typing changes on colorjs.io v6 at lib/src/value/color.ts |
|
@dependabot recreate |
Bumps [colorjs.io](https://github.com/color-js/color.js) from 0.5.2 to 0.6.0. - [Release notes](https://github.com/color-js/color.js/releases) - [Commits](color-js/color.js@v0.5.2...v0.6.0) --- updated-dependencies: - dependency-name: colorjs.io dependency-version: 0.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
65825fb to
28089c0
Compare
|
@nex3, Actually, I wasn't able to complete this upgrade. Besides having to add this to "paths": {
"colorjs.io": "node_modules/colorjs.io/...something.../types.d.ts"
}The API for |
|
That error doesn't looks like a missing channel error so much as a straightforward difference in a color calculation. Can you reduce it to a minimal example that just uses the Color.js API so we can examine it more closely? |
I think the change you need is: {
"compilerOptions": {
"moduleResolution": "node16"
}
} |
|
Re:なつき - Updating Anyways, the colorjsio API (and behavior?) did change between versions, so this PR will need additional changes |
On node >=20.19.0, you can now
My take is that let's bump the required node version to >=20.19.0 once Ubuntu 26.04 is out, and that should solve a lot CJS/ESM compatibility issues. In fact, we have a similar situation on chokidar 5.0 upgrade on dart-sass side, which I propose to take the same approach after April. |
|
I think @ntkme's proposal here is sound. |
|
Superseded by #415. |
Bumps colorjs.io from 0.5.2 to 0.6.0.
Release notes
Sourced from colorjs.io's releases.
... (truncated)
Commits
ff3e6bdRelease 0.6.05570547More v0.6.0 changelog tweaks (#698)9478a14[tests] Fix HTML-tests runner (#700)6107be6[docs] Fix reference1171ed7Documentcollapse: false, closes #2661b2c61bv0.6.0 changelog (#696)af7bcacUpdate README download countc81d5e9Update README download count3a50f04Update README download count2dfe7a8Update README download countDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)