Repository navigation
feat(core): trace lifecycle helper and first-text delivery stages - #29
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core latency logs could not associate lifecycle work within a reconcile pass or distinguish first-text receipt, committed public events, and SSE delivery. This change adds bounded observations for those boundaries and for the E2B helper's parent invocation, Python startup, and execute interval.
First-text observations associate the source execution ordinal with the actual generated public EventID. A failed or uncertain append does not claim that a candidate event was committed; an idempotent replay without a public mapping remains unobserved. SSE observations select the first nonempty text for each observed Turn in a connection, with a fixed non-evicting limit, and record Write and Flush outcomes without claiming client receipt.
No public API, Runtime wire, SQL, scheduling order, or provider SDK operation order changes. Helper changes ship with the Core image; this change does not require rebuilding the Runtime template. It adds observability and does not establish a production performance improvement.
Validation: affected observation race tests, real PostgreSQL commit/unknown/rollback/replay/cancellation/delayed-commit cases, two Turns on one SSE connection with authoritative EventID/sequence readback, and HTTP stream regression tests passed. Python helper tests (283), Core build, naming checks, and bilingual documentation checks passed. A fresh independent reviewer checked all 27 changed files and found no P1/P2 findings. The reviewed file hashes were verified again before commit.
The full API race suite reports
TestUnknownMembersRejectWithLinearAllocation: the same command on clean base3f684ae9reproduces the same allocation threshold failures (160 MiB / 10 MiB). This is not reported as a passing suite or attributed to this patch. No unrelated test was changed. Real production timing verification remains pending deployment.