feat: Enable IAM instance profile (IAM role) when used in AWS#3016
Open
ntnamazu wants to merge 7 commits intosameersbn:masterfrom
Open
feat: Enable IAM instance profile (IAM role) when used in AWS#3016ntnamazu wants to merge 7 commits intosameersbn:masterfrom
ntnamazu wants to merge 7 commits intosameersbn:masterfrom
Conversation
…AFORM STATE, and LFS functions
ntnamazu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitLab have supported IAM instance profile (IAM role) functionality as stated in official documentations like this:
The code of this Pull Request enables to address the feature above. If this feature become available, dockerized GitLab booted on AWS will not require secret access key, so users can eliminate the hassle of managing access keys.
I guess this funciontality is very useful for users deploying dockerized GitLab in AWS. I know there have been a request for this feature like Issue #2526, and if the code of this Pull Request is merged, I guess the issue #2526 can be closed.
This feature was something I wanted very much myself, so I guess some of the other users will find it useful.
I would be happy if this code reviewed.