fix(mcp): exit cleanly on SIGTERM/SIGINT/stdin-end in MCP server#475
Open
JLMA-Agentic-Ai wants to merge 1 commit into
Open
fix(mcp): exit cleanly on SIGTERM/SIGINT/stdin-end in MCP server#475JLMA-Agentic-Ai wants to merge 1 commit into
JLMA-Agentic-Ai wants to merge 1 commit into
Conversation
bin/mcp-server.js had no termination signal handlers. When the parent process is killed with SIGKILL or the connection drops without closing stdin gracefully, the MCP server continues running and is reparented to init (PPID=1), where it accumulates indefinitely and consumes RSS for the lifetime of the user session. Add SIGINT, SIGTERM, and stdin 'end' handlers in main() that call process.exit(0). Adds a regression test (test/sigterm-cleanup.js) that spawns the MCP server, sends each signal, and asserts a clean exit within 5 seconds. Wires the new test into the npm test script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/mcp-server.js had no termination signal handlers. When the parent process is killed with SIGKILL or the connection drops without closing stdin gracefully, the MCP server continues running and is reparented to init (PPID=1), where it accumulates indefinitely and consumes RSS for the lifetime of the user session.
Add SIGINT, SIGTERM, and stdin 'end' handlers in main() that call process.exit(0).
Adds a regression test (test/sigterm-cleanup.js) that spawns the MCP server, sends each signal, and asserts a clean exit within 5 seconds. Wires the new test into the npm test script.